Fix #14959 (Warning hash for token-based warnings) - #8778
Open
danmar wants to merge 4 commits into
Open
Conversation
There was a problem hiding this comment.
Pull request overview
This PR introduces deterministic “warning hash” generation for token-based warnings by computing and emitting a hash attribute in XML output, and updates build dependencies and CLI tests accordingly.
Changes:
- Compute and store a warning hash from token callstacks/error paths in
ErrorMessage. - Emit the
hashattribute in XML output and update CLI XML-output expectations. - Update Makefile dependency lists to reflect new header usage.
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| test/cli/other_test.py | Updates expected XML output to include the new hash attribute. |
| oss-fuzz/Makefile | Adds missing header dependencies for errorlogger.o in the OSS-Fuzz build. |
| Makefile | Adds missing header dependencies for errorlogger.o in the main build. |
| lib/errorlogger.h | Declares ErrorMessage::calculateWarningHash helper. |
| lib/errorlogger.cpp | Implements warning hash computation and wires it into relevant constructors. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.